Project

General

Profile

Actions
Copy link

Feature #1372

closed

GA - technical improvements from Promodo

Added by Anonymous over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
01 Sep 2021
Due date:
% Done:

100%

Estimated time:
Spent time:
50.75 h

Description

Technical requirements - https://docs.google.com/document/d/1ATwGD2ev9ZLrH_LrHu0K8nDfz27x4j1AnFclUU_QCp4/edit
You don't need to do the code in red.

Files

Download all files
Screenshot_6.jpg (157 KB) Screenshot_6.jpg Anonymous, 23 Dec 2021 07:50 AM
Screenshot_7.jpg (214 KB) Screenshot_7.jpg Anonymous, 23 Dec 2021 07:54 AM
Screenshot_6.jpg
Screenshot_7.jpg
Actions
Copy link
 #1

Updated by Anonymous over 4 years ago

  • Tracker changed from Bug to Feature
Actions
Copy link
 #2

Updated by Anonymous over 4 years ago

  • Subject changed from GA - technical improvments from Promodo to GA - technical improvements from Promodo
Actions
Copy link
 #3

Updated by Anonymous over 4 years ago

  • Description updated (diff)
  • Assignee changed from Mykola Romanov to Yevgen Voronetskyy
Actions
Copy link
 #4

Updated by Yevgen Voronetskyy over 4 years ago

  • Status changed from New to In Progress
  • Assignee changed from Yevgen Voronetskyy to Anonymous
  • The specification is not clear about 'Category 1/Subcategory 11' - it's universe/subUniverse ?
  • if brend field is empty, what should we do ?
Actions
Copy link
 #5

Updated by Yevgen Voronetskyy over 4 years ago

workload estimate

  • link the family/universe graph to productDTO - 9 days
  • add jUnit tests - 1 day
  • modify 7 scripts/steps described in spec - 2 days

Total: 12 days

Actions
Copy link
 #6

Updated by Yevgen Voronetskyy about 4 years ago

universe/family problem investigation

It's difficult to find out the exact place and date when the universe/family information was removed from GA integration.
One thing I see that the initial GA was developed by Max Ivanov under #797 the ticket and refactored by us under the ticker #1009.

Actions
Copy link
 #7

Updated by Yevgen Voronetskyy about 4 years ago

updated workload estimate

As we agreed with @o.skrypek during today call, we will fix the issue described in precedent note for 4.5 d

  1. link the family/universe graph to productDTO - 4.5 days
  2. add jUnit tests - 1 day
  3. modify 7 scripts/steps described in spec - 2 days

Total: 7.5 days

Actions
Copy link
 #8

Updated by Mykola Romanov about 4 years ago

we approve

Actions
Copy link
 #9

Updated by Anonymous almost 4 years ago

Please, write the categories in ukr language.

Actions
Copy link Download all files
 #10

Updated by Anonymous almost 4 years ago

Screenshot_6.jpg
Screenshot_7.jpg

We don't have the information about Brand, I think starting from all checkout process. In the screenshot there is information about created orders, there is no Brands. Only default values.

Also we have too much Default categories during the day (not just after restart). I check the products what was bought and saw that there is no breadcrumbs for some period of time for these products.

Ex:
11659284

Actions
Copy link
 #11

Updated by Yevgen Voronetskyy almost 4 years ago

Workaround for failed family fetching from OPUS

The breadcrumbs generation relays 100% on OPUS fetching. For unknown reasons, random families and even universes failed to be fetched from OPUS. The breadcrumbs for concerning products are null before next server restart.

We propose to store the generated breadcrumbs graph on the file system and update it during the dynamic fetching.
This solution will allow us to ALWAYS have the breadcrumbs.

workload estimate

  • developing of new architecture for breadcrumbs - 4 dyas
  • jUnit tests - 1 days

Total: 5 days

Actions
Copy link
 #12

Updated by Mykola Romanov almost 4 years ago

we approve

Actions
Copy link
 #13

Updated by Yevgen Voronetskyy almost 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Dev is done for the first part. Fix for null brand name on payment page is in master.

Actions
Copy link
 #14

Updated by Yevgen Voronetskyy almost 4 years ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Anonymous to Yevgen Voronetskyy
  • % Done changed from 100 to 50
Actions
Copy link
 #15

Updated by Olek Mark almost 4 years ago

New settings:

breadcrumbs.backup.full-filename:breadcrumbs.json - Breadcrumbs repository full file name (Read/Write access is a must)
job.breadcrumbs.delay.initial.in.millis:120000 - time before service start (earlier it was hardcoded)
job.breadcrumbs.generation-check-interval.in.millis:10000 - time between generation process observation checks (earlier it was hardcoded)

Actions
Copy link
 #16

Updated by Yevgen Voronetskyy almost 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Yevgen Voronetskyy to Anonymous
  • % Done changed from 50 to 100

Part 2 of the task (breadcrumbs persistence) is done and deployed on production yesterday.

Actions
Copy link
 #17

Updated by Anonymous almost 4 years ago

  • Status changed from Resolved to Closed

Done!

Actions
Copy link
 #18

Updated by Anonymous almost 4 years ago

I double checked and it looks good!

Actions
Copy link

Also available in: Atom PDF